Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

benchmark script: remove file name for --output argument #2998

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Aug 11, 2023

RRemove the file name from the --output argument for the command that benchmarks the runtimes.

The benchmark CLI tool will automatically resolve the name if it's not provided. In cases where there are multiple instances of one pallet within a single runtime, the file name needs an instance name to avoid a collision. This is already supported by the CLI tool if the file name is omitted in the --output.

The current change to the script does not affect the name resolutions for the existing weights' files.
This change is required for this PR. - #2002

@muharem muharem added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 11, 2023
@@ -48,5 +48,5 @@ do
--repeat=$repeat \
--json \
--header=./file_header.txt \
--output="${benchmarkOutput}/${output_file}.rs" >> $artifactsDir/${pallet}_benchmark.json
--output="${benchmarkOutput}/${output_dir}" >> $artifactsDir/${pallet}_benchmark.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the artifacts/json file names still can collide.
I will address it later if we merge this - paritytech/substrate#14757

@muharem
Copy link
Contributor Author

muharem commented Aug 21, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ba844a9 into master Aug 21, 2023
14 checks passed
@paritytech-processbot paritytech-processbot bot deleted the muharem-bench-script branch August 21, 2023 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants