Fix building parcel with a debug build of itself #9829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a segmentation fault in parcel when building itself using a debug build of its native extensions. This would previously crash due to usage of `Fold` and its recursive nature. All expressions will recurse in the typeof replacer code, so SWC will crash if a module has large enough expressions, which is a case that does happen within parcel own dependencies. This should improve performance and is the recommended usage by SWC * #9828 We should replace all SWC transformations from `Fold` to `VisitMut`. /discussions/9828
| @@ -388,7 +384,12 @@ pub fn transform( | |||
| ), | |||
| ); | |||
|
|
|||
| module.fold_with(&mut passes) | |||
| let mut module = module.fold_with(&mut passes); | |||
| if config.source_type != SourceType::Script { | |||
There was a problem hiding this comment.
Should this be done before passes so that the other optimisations (e.g. dead branch, paren remover, etc) are guaranteed to execute?
There was a problem hiding this comment.
Yes I think you're right; I've put it back in the same place surrounded with an as_folder which will wrap the visit-mut with a top-level Fold instance that just implements fold_module by calling into the visitor
MonicaOlejniczak
approved these changes
Jul 1, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a segmentation fault in parcel when building itself using a debug build of its native extensions.
This would previously crash due to usage of
Foldand its recursive nature.All expressions will recurse in the typeof replacer code, so SWC will crash if a module has large enough expressions, which is a case that does happen within parcel own dependencies.
This should improve performance and is the recommended usage by SWC
FoldtoVisitMut./discussions/9828