Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration from SWC Fold to VisitMut #9854

Open
4 of 7 tasks
yamadapc opened this issue Jul 17, 2024 · 0 comments
Open
4 of 7 tasks

Migration from SWC Fold to VisitMut #9854

yamadapc opened this issue Jul 17, 2024 · 0 comments

Comments

@yamadapc
Copy link
Contributor

yamadapc commented Jul 17, 2024 •
edited by MonicaOlejniczak
Loading

At the moment parcel will segfault on certain cases due to running out of stack space.

This is due to usage of SWC Fold primitive.

https://rustdoc.swc.rs/swc_visit/index.html#fold-vs-visitmut

This issue will track replacing usage of Fold with VisitMut and improving test coverage of the SWC transformations built into parcel's default JS transformer.
yamadapc pushed a commit that referenced this issue Jul 17, 2024
@pyamada-atlassian
Add exhaustive tests for NodeReplacer
d416b92 
This is related to #9854.

A subsequent commit will add a VisitMut implementation and switch it over.
yamadapc pushed a commit that referenced this issue Jul 17, 2024
@pyamada-atlassian
Refactor node replacer to use VisitMut
383a13b 
This contributes to #9854.
yamadapc added a commit that referenced this issue Jul 18, 2024
@yamadapc @pyamada-atlassian
Refactor node replacer to use VisitMut (#9855)
32f5a15 
* Add exhaustive tests for NodeReplacer

This is related to #9854.

A subsequent commit will add a VisitMut implementation and switch it over.

* Refactor node replacer to use VisitMut

This contributes to #9854.

---------

Co-authored-by: pyamada (RDE) <pyamada@atlassian.com>
yamadapc added a commit to yamadapc/parcel that referenced this issue Jul 18, 2024
@yamadapc
Update with SWC test utils test
fab0eee 
This is part of parcel-bundler#9854
yamadapc pushed a commit that referenced this issue Jul 26, 2024
@pyamada-atlassian
Add tests for dependency collector
c40341c 
This contributes to #9854.
@yamadapc yamadapc mentioned this issue Jul 26, 2024
Merged
yamadapc pushed a commit that referenced this issue Jul 26, 2024
@pyamada-atlassian
Add tests for dependency collector
593d767 
This contributes to #9854.

This isn't exhaustive because there are quite a few branches related to
library and script builds.
yamadapc added a commit that referenced this issue Jul 26, 2024
@yamadapc @pyamada-atlassian
Add tests for dependency collector (#9874)
b5e176d 
This contributes to #9854.

This isn't exhaustive because there are quite a few branches related to
library and script builds.

Co-authored-by: pyamada (RDE) <pyamada@atlassian.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yamadapc