-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS fixes and dependency upgrades #7564
Conversation
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
This partially reverts commit a313f76.
Ended up reverting the babel upgrade because it caused a significant performance regression. Parcel's code compiled with the new Babel runs slower for some reason... |
AFAICT, the only change from the Babel upgrade (so the state before the "Revert babel upgrade" commit) is that public and private class properties are transpiled. |
Oh that's weird! Why would Babel start transpiling class properties? |
Hmm well I think it was working for us before just fine. Plus, node 12 is almost out of LTS (in April) so I'm not too concerned. Better to keep the improved performance. |
preset-env 7.14.0 is the first version that transpiles them, it works fine with {
"dependencies": {
"@babel/cli": "^7.16.8",
"@babel/core": "^7.16.7",
"@babel/preset-env": "^7.13.0"
}
} So probably somehow caused by babel/babel#13091
Bumping the target from Node 12 to Node 14 still transpiles them. It's only with 16 that they are left in |
It's weird because this still shows node 12: https://github.com/babel/babel/blob/main/packages/babel-compat-data/data/plugins.json#L25. But running with the debug option in preset env shows this:
I thought maybe disabling class static block, etc. would help but it was still transpiled with: exclude: [
'@babel/plugin-proposal-private-methods',
'@babel/plugin-proposal-private-property-in-object',
'@babel/plugin-proposal-class-static-block'
] |
Going to merge this for now so we can get the security upgrades out, and file an issue with Babel. |
@parcel/css
, but it resulted in a bug. Now we preserve the quotes, and I added them to Parcel CSS as well to match. That way we don't need to deal with escaping. That will be handled by the minifier if needed.Also updates a bunch of dependencies to fix security warnings and reduce the number of duplicates we have:
Hopefully these solve the security audit issues for now, and starts to reduce the number of dependencies we have.