Do not compile with babel by default #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
DeMoorJasper
reviewed
Jul 3, 2020
DeMoorJasper
approved these changes
Jul 6, 2020
|
If this gets merged we do need to update the docs: https://v2.parceljs.org/getting-started/webapp/#browserslist |
Will this some cause some problems with IE11 for @wbinnssmith ? And maybe we should off on this until Babel can be configured to force transpilation of (some) node_modules ( |
Can this and similar statements be expanded to include the non-package.json equivalents like the .browserslistrc file, if that's not already implicitly the case to people in this project? Those alternatives are an established concept already for configuration, so they should consistently remain first class citizens. I don't like polluting package.json with all kinds of arbitrary config if I have a choice. |
This should definitely be the case, I'm not sure if this change actually respects that though |
|
It should. It's the TargetResolver's responsibility to read browserslist configs, and the babel transformer just uses the pre-resolved targets so I don't think any changes should be needed for that. |
mischnic
reviewed
Oct 26, 2020
Comment on lines
-54
to
-61
| root: options.projectRoot, | ||
| babelrcRoots, |
There was a problem hiding this comment.
Why did you remove these options?
There was a problem hiding this comment.
I believe setting the cwd to the projectRoot makes babel able to find the root config itself rather than needing us to pass them in.
…ults # Conflicts: # packages/core/core/test/TargetRequest.test.js # packages/core/integration-tests/test/babel.js # packages/transformers/babel/src/config.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables babel compilation by default, for both development and production builds, unless one or more of the following are true:
browserslistin your package.json.If none of these are true, code will be passed through un-transpiled. In addition:
flow-binin the dependencies of the package.json in the root of your project.The reasoning behind this is as follows:
Closes T-525