fix fee history #9940
fix fee history #9940
Conversation
| let pending_block_hash = if is_pending_block { | ||
| if let Some(pending_block) = self.block(BlockNumberOrTag::Pending.into()).await? { |
There was a problem hiding this comment.
we can make this slightly nicer by storing the pending block as an option and effectively collapse these two checks
as discussed also need to use
because we need the receipts as well, because we need them for the rewards
this issue is somewhat related here but not a blocker
| @@ -154,11 +155,23 @@ pub trait EthFees: LoadFee { | |||
| base_fee_per_blob_gas.push(last_entry.next_block_blob_fee().unwrap_or_default()); | |||
| } else { | |||
There was a problem hiding this comment.
there are two modes in this impl, one where everything is cached,, the if branch of this else branch, in which we'd also need to add an additional entry for the pending block.
so it would make sense to calculate the pending things above the if statement and then update the fee entries or the non-cached mode accordingly
mattsse
added
C-bug
|
Any updates on this issue? |
|
Yes, I am going to get this over the line, sorry for the delay |
|
Any updates on review ? |
|
think @onbjerg means he will push changes to the branch and get your commits in along with his to push this over the line |
Closes #9903