Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store receipts for local pending block #9948

Closed
mattsse opened this issue Jul 31, 2024 · 3 comments · Fixed by #10597
Closed

store receipts for local pending block #9948

mattsse opened this issue Jul 31, 2024 · 3 comments · Fixed by #10597
Assignees
@malik672
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 31, 2024 •
edited
Loading

Describe the feature

currently we don't store the receipts for the pending block we just built

reth/crates/rpc/rpc-eth-types/src/pending_block.rs

Line 118 in 750eb26

pub struct PendingBlock {

and for eth_getBlockreceipts we don't check the local block

reth/crates/rpc/rpc-eth-api/src/helpers/block.rs

Line 154 in 750eb26

.pending_block_and_receipts()

TODO

  • store receipts for locally built block and integrate in LoadPendingBlock

cc @loocapro

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Jul 31, 2024
@mattsse mattsse mentioned this issue Jul 31, 2024
Closed
@malik672
Copy link
Contributor

malik672 commented Aug 2, 2024

@mattsse assign me

@malik672 malik672 mentioned this issue Aug 4, 2024
Closed
@Parikalp-Bhardwaj
Copy link
Contributor

Hi @malik672 are you still working on this issue?

@malik672
Copy link
Contributor

malik672 commented Aug 7, 2024

yeah

@malik672 malik672 mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malik672 malik672

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pending receipt malik672/reth
feat: store receipts for local pending block malik672/reth
3 participants
@mattsse @Parikalp-Bhardwaj @malik672