Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): add empty receipts for genesis if first block is one #9769

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 24, 2024

Closes #9627

Allows for importing receipts from block 0.

@emhane emhane added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth labels Jul 24, 2024
@emhane emhane marked this pull request as draft July 24, 2024 15:08
@emhane emhane force-pushed the dan/apply-first-block-one-fix branch from 3057e15 to e2b2233 Compare July 24, 2024 15:13
@emhane emhane marked this pull request as ready for review July 26, 2024 00:04
@emhane
Copy link
Member Author

emhane commented Jul 26, 2024

as issue mentions, import receipts expects receipts file to start at block 1

Error: trying to append data to Receipts as block #0 but expected block #1

I can't find where in the op block import command that receipts static files is initialised yet, so couldn't manually tigger it in the test. probably happens somewhere in pipeline. the test fails, with output trying to append data to Receipts as block #1 but expected block #0, which means that the fix works as we want. if import receipts command becomes generalised for any chain in future, we should probably spend time debugging this test. didn't feel it was necessary to look closer at this atm, so marked test as ignore.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@emhane emhane added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 0a4b717 Jul 26, 2024
33 checks passed
@emhane emhane deleted the dan/apply-first-block-one-fix branch July 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-reth: import receipts issue
3 participants