Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add rustfmt.toml #1

Merged
merged 1 commit into from
Sep 21, 2022
Merged

chore: add rustfmt.toml #1

merged 1 commit into from
Sep 21, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 21, 2022

add same rustfmt.toml as foundry

@onbjerg onbjerg merged commit 80ff879 into master Sep 21, 2022
@gakonst gakonst deleted the matt/add-rustfmt-toml branch September 27, 2022 17:56
gakonst added a commit that referenced this pull request Feb 15, 2023
unfortunately alpine seems to be causing issues when used in hive

    /reth.sh: line 78: /usr/local/bin/reth: cannot execute: required file not found

presumably because of some glibc issue

Running uname in the reth.sh we get a 64 linux machine:
Linux dc5b3a394e6c 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 x86_64 Linux

So maybe we would run docker build with --platform=linux/amd64, but this also did not work

     => [builder 4/4] RUN cd reth && cargo build --all --locked --profile release                                                                                                                                                                                                                                                                         418.3s
     => => # <jemalloc>: MADV_DONTNEED does not work (memset will be used instead)
     => => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
     => => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
     => => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
     => => # <jemalloc>: MADV_DONTNEED does not work (memset will be used instead)
     => => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
    invalid character 'c' looking for beginning of value

So I decided to bite the bullet and just switch this over to Ubuntu, and if it's a problem
we will fix it later.
clabby referenced this pull request in clabby/reth Mar 5, 2023
Small changes to the deposit tx primitive
Jackmeng1985 added a commit to Jackmeng1985/reth that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants