Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sanity_check implementation for block headers #5863

Merged
merged 2 commits into from
Dec 27, 2023
Merged

feat: add sanity_check implementation for block headers #5863

merged 2 commits into from
Dec 27, 2023

Conversation

tcoratger
Copy link
Contributor

Should close #5800.

mattsse
mattsse requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, supportive, only naming nits

crates/primitives/src/header.rs Outdated Show resolved Hide resolved
crates/primitives/src/header.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-enhancement New feature or request label Dec 27, 2023
@mattsse mattsse added this pull request to the merge queue Dec 27, 2023
Merged via the queue into paradigmxyz:main with commit e861f2b Dec 27, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add sanity_check implementation for block headers
2 participants
@tcoratger @mattsse