Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sanity_check implementation for block headers #5800

Closed
tcoratger opened this issue Dec 17, 2023 · 0 comments · Fixed by #5863
Closed

feat: add sanity_check implementation for block headers #5800

tcoratger opened this issue Dec 17, 2023 · 0 comments · Fixed by #5863
Labels
C-enhancement New feature or request

Comments

@tcoratger
Copy link
Contributor

tcoratger commented Dec 17, 2023

Describe the feature

Sometimes, we need to protect the system against potential DOS attack. In this sense, it could be nice to have a method to ensure the validity of critical values within the block header. We could implement a global sanity check method for the Header structure, similar to the approach demonstrated here.

While our block numbers (natively u64) already enforce one aspect, expanding this with additional tests for other header values accompanied by dedicated error handling could significantly enhance our system's security.

Proposed Changes:

  • Introduce a global sanity check method for the Header structure.
  • Add tests for various header values with dedicated error handling.

These changes are aimed at strengthening our system's defenses and ensuring the integrity of block header data.

Additional context

No response

@tcoratger tcoratger added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 17, 2023
@DaniPopes DaniPopes removed the S-needs-triage This issue needs to be labelled label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants