Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: omit output if empty #4138

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: omit output if empty #4138

merged 1 commit into from
Aug 10, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 10, 2023

@mattsse mattsse requested a review from Rjected as a code owner August 10, 2023 10:53
@mattsse mattsse added M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #4138 (d38c3a6) into main (4de1ff0) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/trace/geth/call.rs 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.86% <0.00%> (-0.01%) ⬇️
unit-tests 64.06% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.67% <ø> (-0.05%) ⬇️
txpool 47.66% <ø> (ø)
networking 77.68% <ø> (-0.05%) ⬇️
rpc 58.68% <ø> (-0.03%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <0.00%> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.91% <ø> (ø)

@mattsse mattsse requested a review from joshieDo August 10, 2023 11:14
@mattsse mattsse added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit a808f7c Aug 10, 2023
24 checks passed
@mattsse mattsse deleted the matt/omit-output-if-empty branch August 10, 2023 13:07
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @alessandromazza98
fix: omit output if empty (paradigmxyz#4138)
7d188f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @joshieDo