fix: omit output if empty

paradigmxyz · Aug 10, 2023 · 44e8ed4 · 44e8ed4
1 parent 4de1ff0
commit 44e8ed4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/crates/revm/revm-inspectors/src/tracing/types.rs b/crates/revm/revm-inspectors/src/tracing/types.rs
@@ -438,7 +438,7 @@ impl CallTraceNode {
             gas: U256::from(self.trace.gas_limit),
             gas_used: U256::from(self.trace.gas_used),
             input: self.trace.data.clone().into(),
-            output: Some(self.trace.output.clone().into()),
+            output: (!self.trace.output.is_empty()).then(|| self.trace.output.clone().into()),
             error: None,
             revert_reason: None,
             calls: Default::default(),

diff --git a/crates/rpc/rpc-types/src/eth/trace/geth/call.rs b/crates/rpc/rpc-types/src/eth/trace/geth/call.rs
@@ -1,6 +1,8 @@
 use reth_primitives::{serde_helper::num::from_int_or_hex, Address, Bytes, H256, U256};
 use serde::{Deserialize, Serialize};
 
+/// The response object for `debug_traceTransaction` with `"tracer": "callTracer"`
+///
 /// <https://github.com/ethereum/go-ethereum/blob/91cb6f863a965481e51d5d9c0e5ccd54796fd967/eth/tracers/native/call.go#L44>
 #[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct CallFrame {
@@ -11,6 +13,7 @@ pub struct CallFrame {
     pub gas_used: U256,
     #[serde(default, skip_serializing_if = "Option::is_none")]
     pub to: Option<Address>,
+    #[serde(default, skip_serializing_if = "Option::is_none")]
     pub input: Bytes,
     #[serde(default, skip_serializing_if = "Option::is_none")]
     pub output: Option<Bytes>,