Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): storage tries recovery #4109

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Aug 8, 2023

Description

Recovery script for the bug addressed in #4108

@rkrasiuk rkrasiuk added the A-cli Related to the reth CLI label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4109 (dd9b7a3) into main (aaf2d2c) will decrease coverage by 0.14%.
Report is 7 commits behind head on main.
The diff coverage is 6.66%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli/mod.rs 34.04% <0.00%> (-0.37%) ⬇️
bin/reth/src/recover/mod.rs 0.00% <0.00%> (ø)
bin/reth/src/recover/storage_tries.rs 7.89% <7.89%> (ø)

... and 38 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.48% <0.00%> (-0.02%) ⬇️
unit-tests 63.88% <6.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.36% <6.66%> (-0.15%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.59% <ø> (+0.02%) ⬆️
trie 94.70% <ø> (ø)
txpool 47.59% <ø> (-0.78%) ⬇️
networking 77.46% <ø> (+0.01%) ⬆️
rpc 57.47% <ø> (+0.01%) ⬆️
consensus 63.76% <ø> (-0.32%) ⬇️
revm 32.26% <ø> (-0.28%) ⬇️
payload builder 6.57% <ø> (-0.02%) ⬇️
primitives 87.76% <ø> (-0.26%) ⬇️

@rkrasiuk rkrasiuk marked this pull request as ready for review August 8, 2023 06:06
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner August 8, 2023 06:06
@rkrasiuk rkrasiuk added the M-changelog This change should be included in the changelog label Aug 8, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk enabled auto-merge August 8, 2023 08:56
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 32dd9af Aug 8, 2023
24 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/storage-tries-recovery branch August 8, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants