fix(trie): dangling storage hashes

[rkrasiuk]

Description

If we compute the state root incrementally for a block range where the account got self-destructed, there is a possibility that the intermediate hashes of its storage trie would not be deleted. If the account is re-created later, its previous intermediate hashes might be considered a part of the current storage trie. This is addressed by always removing the storage nodes for any account that has been destroyed.

Should close #4107

[codecov]

Codecov Report

Merging #4108 (818b1ee) into main (aaf2d2c) will decrease coverage by 0.11%.
Report is 7 commits behind head on main.
The diff coverage is 93.84%.

Files Changed	Coverage Δ
crates/storage/provider/src/traits/hashing.rs	0.00% <ø> (ø)
crates/trie/src/prefix_set/mod.rs	83.11% <ø> (ø)
...torage/provider/src/providers/database/provider.rs	79.58% <89.65%> (-0.02%)	⬇️
crates/trie/src/prefix_set/loader.rs	97.05% <93.75%> (-2.95%)	⬇️
crates/trie/src/trie.rs	96.68% <100.00%> (+0.04%)	⬆️
crates/trie/src/updates.rs	90.24% <100.00%> (+0.37%)	⬆️

... and 37 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	16.51% <0.00%> (+0.01%)	⬆️
unit-tests	63.93% <93.84%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	25.52% <ø> (+<0.01%)	⬆️
blockchain tree	83.04% <ø> (ø)
pipeline	90.07% <ø> (ø)
storage (db)	74.59% <89.65%> (+0.03%)	⬆️
trie	94.71% <97.22%> (+<0.01%)	⬆️
txpool	47.59% <ø> (-0.78%)	⬇️
networking	77.41% <ø> (-0.04%)	⬇️
rpc	57.47% <ø> (+0.01%)	⬆️
consensus	63.76% <ø> (-0.32%)	⬇️
revm	32.26% <ø> (-0.28%)	⬇️
payload builder	6.57% <ø> (-0.02%)	⬇️
primitives	87.76% <ø> (-0.26%)	⬇️

[mattsse]

always selfdestruct

[rkrasiuk]

always!!!