feat(txpool) - add flag for local tx propagation #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0xprames
force-pushed
the
reth-issue-3966
branch
from
e5e79a3
to
2ac06c3
Compare
mattsse
requested changes
Jul 28, 2023
| @@ -185,6 +188,11 @@ impl EthTransactionValidatorBuilder { | |||
| self.eip1559 = eip1559; | |||
| self | |||
| } | |||
| /// Sets the local transaction propagation toggle | |||
There was a problem hiding this comment.
This needs a bit more context:
basically if set to true (default), all locally received transactions (via RPC for example) will be propagated over the network
There was a problem hiding this comment.
makes sense, added a bit more context
mattsse
added
A-rpc
0xprames
force-pushed
the
reth-issue-3966
branch
from
2ac06c3
to
98a49f4
Compare
0xprames
force-pushed
the
reth-issue-3966
branch
from
98a49f4
to
75313b4
Compare
0xprames
force-pushed
the
reth-issue-3966
branch
from
54f4a15
to
143de80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #3966