Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a config value for passing local transactions or not #3966

Closed
mattsse opened this issue Jul 27, 2023 · 1 comment · Fixed by #3977
Closed

Adding a config value for passing local transactions or not #3966

mattsse opened this issue Jul 27, 2023 · 1 comment · Fixed by #3977
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 27, 2023

Describe the feature

/// Whether to propagate the transaction to the network.
propagate: bool,

determines whether a validated tx should be propagated over the network

we want a setting that determines whether a local transaction should be propagate

TODO

add config value to

/// A builder for [EthTransactionValidator]
#[derive(Debug, Clone)]
pub struct EthTransactionValidatorBuilder {

enforce here:

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Jul 27, 2023
@blacktoast
Copy link

Can I take this on?
If possible, I would like to know how to test whether this code is correct or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants