-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use tracing pool for tracing calls #3914
Conversation
8f63f26
to
5828110
Compare
Codecov Report
... and 59 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i like the docs on EthTransactions
and naming that makes it clear what's spawned on the pool
6e9be16
to
2a50fba
Compare
Closes #3904
integrates the new rayon tracing pool in rpc.
simplifies trace_ and debug_: get rid of
on_blocking_task
, insteadEthTransaction
trait spawns those calls.calls that spawn now begin with
spawn_
to make this clear.This simplifies the interface