-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement prestateTracer #3923
WIP: Implement prestateTracer #3923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty good already.
the rpc impls is ready, the tracing logic needs a few changes
a3eb399
to
7fb836e
Compare
@mattsse, let me know if that looks better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice,
almost there
7fb836e
to
87cee89
Compare
@mattsse , should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice,
tysm for this!
Codecov Report
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The following is a WIP for prestatTracer. With regard to that there are a couple of things that I'd ask for help
fn trace_transaction()
given that it won't be satisfied byDatabaseRef
.1.1. Should the signature of
geth_prestate_traces()
be changed to accept a mutable reference and then borrow mutably frominspect_call_at_and_return_state()
that gets called intry_debug_trace_call()
?1.2. Or maybe make a copy of the db object?
Closes #2624