feat: abstract OP payload builder over transaction #14153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
rkrasiuk and
gakonst
as code owners
mattsse
approved these changes
Feb 2, 2025
Comment on lines
55
to
62
| pub trait OpPayloadPrimitives: | ||
| NodePrimitives< | ||
| Receipt: DepositReceipt, | ||
| SignedTx = Self::_TX, | ||
| BlockHeader = Header, | ||
| BlockBody = BlockBody<Self::_TX>, | ||
| > | ||
| { |
There was a problem hiding this comment.
can we move this to traits.rs so that we could move this more easily
klkvr
force-pushed
the
klkvr/generic-op-built-payload
branch
from
725839b to
b67f06a
Compare
klkvr
force-pushed
the
klkvr/generic-op-built-payload
branch
from
b67f06a to
9b912cc
Compare
mattsse
approved these changes
Feb 3, 2025
mattsse
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14152
This is similar to #13792 and is based on the same
OpReceiptBuildertrait.OpBuiltPayloadandOpPayloadBuilderAttributesare made generic over primitive types. With this PROpPayloadBuilderis fully generic over transaction, delegating all execution toConfigureEvm, and receipt building to configuredOpReceiptBuilder, allowing it to be reused for OP rollups with custom transaction types