chore: simplify OpBuiltPayload
#14152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez and
rkrasiuk
as code owners
mattsse
approved these changes
Feb 2, 2025
Comment on lines
+852
to
+855
| pub fn into_sealed_block(self) -> SealedBlock<N::Block> { | ||
| let block = Arc::unwrap_or_clone(self.block.recovered_block); | ||
| block.into_sealed_block() | ||
| } |
Comment on lines
-144
to
-150
| /// The blobs, proofs, and commitments in the block. If the block is pre-cancun, this will be | ||
| /// empty. | ||
| pub(crate) sidecars: Vec<BlobTransactionSidecar>, | ||
| /// The rollup's chainspec. | ||
| pub(crate) chain_spec: Arc<OpChainSpec>, | ||
| /// The payload attributes. | ||
| pub(crate) attributes: OpPayloadBuilderAttributes, |
| /// Block execution data for the payload, if any. | ||
| pub(crate) executed_block: Option<ExecutedBlockWithTrieUpdates<OpPrimitives>>, | ||
| pub(crate) block: ExecutedBlockWithTrieUpdates<OpPrimitives>, |
There was a problem hiding this comment.
I think this is a reasonable, if you need a remote builder you can still write your own builder
| @@ -306,7 +280,8 @@ impl From<OpBuiltPayload> for OpExecutionPayloadEnvelopeV4 { | |||
| // Spec: | |||
| // <https://github.com/ethereum/execution-apis/blob/fe8e13c288c592ec154ce25c534e26cb7ce0530d/src/engine/cancun.md#specification-2> | |||
| should_override_builder: false, | |||
| blobs_bundle: sidecars.into_iter().collect::<Vec<_>>().into(), | |||
| // No blobs for OP. | |||
| blobs_bundle: BlobsBundleV1 { blobs: vec![], commitments: vec![], proofs: vec![] }, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to keep ChainSpec, attributes and blobs in OpBuiltPayload.
This should make it easier to reuse the type with custom blocks