Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eth-wire-types): add snap sync protocol types #14119

Merged
merged 3 commits into from
Jan 31, 2025
Merged

feat(eth-wire-types): add snap sync protocol types #14119

merged 3 commits into from
Jan 31, 2025

Conversation

lean-apple
Copy link
Contributor

@emhane emhane added the A-networking Related to networking in general label Jan 31, 2025
emhane
emhane approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super neat, thanks a lot

mattsse
mattsse reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

this is great, only needs some docs, or we ignore them for this mod + passing CI.

we likely also need rlp support for all of these, but this can be tackled separately or in this pr

@lean-apple
Copy link
Contributor Author

lgtm!

this is great, only needs some docs, or we ignore them for this mod + passing CI.

we likely also need rlp support for all of these, but this can be tackled separately or in this pr

Let me finish the documentation to make it ready to review, I would prefer to do the rlp support in another PR if it is ok :)

@lean-apple lean-apple marked this pull request as ready for review January 31, 2025 13:56
@lean-apple lean-apple requested a review from Rjected as a code owner January 31, 2025 13:56
mattsse
mattsse approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@mattsse mattsse added this pull request to the merge queue Jan 31, 2025
Merged via the queue into paradigmxyz:main with commit bf20c78 Jan 31, 2025
44 checks passed
@lean-apple lean-apple deleted the snap-protocol-types branch February 1, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add types for ethereum snap sync protocol
3 participants
@lean-apple @mattsse @emhane