Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for ethereum snap sync protocol #14006

Closed
mattsse opened this issue Jan 27, 2025 · 3 comments · Fixed by #14119
Closed

Add types for ethereum snap sync protocol #14006

mattsse opened this issue Jan 27, 2025 · 3 comments · Fixed by #14119
Assignees
@lean-apple
Labels
A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 27, 2025

Describe the feature

we're missing proper types for the snapsync protocol

https://github.com/ethereum/devp2p/blob/master/caps/snap.md#protocol-messages

TODO

  • add types for snapsync to eth-wire-types crate

similar to:

reth/crates/net/eth-wire-types/src/message.rs

Line 174 in b9a6e65

pub enum EthMessage<N: NetworkPrimitives = EthNetworkPrimitives> {

This PR should only focus on the type-defs

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 27, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-networking Related to networking in general and removed S-needs-triage This issue needs to be labelled labels Jan 27, 2025
@lean-apple
Copy link
Contributor

Hello, can I work on it ?

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 27, 2025

awesome,
I think we can add all of this under a new mod called snap.rs

@Nanle100
Copy link

Could I be assigned to this?

@lean-apple lean-apple mentioned this issue Jan 30, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lean-apple lean-apple

Labels
A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eth-wire-types): add snap sync protocol types lean-apple/reth
3 participants
@mattsse @lean-apple @Nanle100