fix: Add dummy system tx in op dev mode #14062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisht13
requested review from
mattsse,
Rjected,
fgimenez,
rkrasiuk and
gakonst
as code owners
|
@mattsse let me know if you want me to add tests for the same as well! |
mattsse
requested changes
Jan 29, 2025
| /// OP Mainnet transaction at index 0 in block 124665056. | ||
| /// | ||
| /// <https://optimistic.etherscan.io/tx/0x312e290cf36df704a2217b015d6455396830b0ce678b860ebfcc30f41403d7b1> | ||
| pub const TX_SET_L1_BLOCK_OP_MAINNET_BLOCK_124665056: [u8; 251] = hex!("7ef8f8a0683079df94aa5b9cf86687d739a60a9b4f0835e520ec4d664e2e415dca17a6df94deaddeaddeaddeaddeaddeaddeaddeaddead00019442000000000000000000000000000000000000158080830f424080b8a4440a5e200000146b000f79c500000000000000040000000066d052e700000000013ad8a3000000000000000000000000000000000000000000000000000000003ef1278700000000000000000000000000000000000000000000000000000000000000012fdf87b89884a61e74b322bbcf60386f543bfae7827725efaaf0ab1de2294a590000000000000000000000006887246668a3b87f54deb3b94ba47a6f63f32985"); |
There was a problem hiding this comment.
this should probably solve the rpc issues that @Quertyy faced
I consider this a nice short term fix, we can make this a bit smarter in followups,
e.g. actually crafting a system tx.
but before we can do this we need to solve a few other things that I'll scope now
Bisht13
force-pushed
the
fix/op-dev-chain-tx
branch
from
ef5bd50 to
ee1df52
Compare
mattsse
approved these changes
Jan 30, 2025
|
@Quertyy confirmed that this fixes the issue, this (hacky) solution is only temporary, working on improvements separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dummy system transaction in op reth if it is run in
devmode.closes #14005
closes #13991