Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not use op-reth in dev mode #13991

Closed
1 task done
Quertyy opened this issue Jan 25, 2025 · 3 comments · Fixed by #14062
Closed
1 task done

Can not use op-reth in dev mode #13991

Quertyy opened this issue Jan 25, 2025 · 3 comments · Fixed by #14062
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior

Comments

@Quertyy
Copy link
Contributor

Quertyy commented Jan 25, 2025

Describe the bug

When using op-reth with the flag --dev it's not possible to send transaction, the error could not get L1 block info from L2 block is triggered.

if let Some(Ok(cost_addition)) = tx.map(reth_optimism_evm::extract_l1_info_from_tx) {
*self.block_info.l1_block_info.write() = cost_addition;
}

let mut l1_block_info =
reth_optimism_evm::extract_l1_info(block.body()).map_err(OpEthApiError::from)?;

The extraction should not occur, or the error should be handled in dev mode.

Steps to reproduce

  1. Run op-reth in dev mode: op-reth node --dev --http --http.api all --dev.block-max-transactions 1
  2. Use cast to make a native transfer: cast send --value 1000000000000000000 0x3fAB184622Dc19b6109349B94811493BF2a45362 --rpc-url=http://localhost:8545 --private-key "0x2a871d0798f97d79848a013d4936a73bf4cc922c825d33c1cf7073dff6d409c6"

Node logs

From cast:

Error: server returned an error response: error code -32603: could not get L1 block info from L2 block: invalid l1 block info transaction calldata in the L2 block

Platform(s)

No response

Container Type

Not running in a container

What version/commit are you on?

reth-optimism-cli Version: 1.1.5

What database version are you on?

N/A

Which chain / network are you on?

dev

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

make install-op

Code of Conduct

  • I agree to follow the Code of Conduct
@Quertyy Quertyy added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Jan 25, 2025
@mattsse
Copy link
Collaborator

mattsse commented Jan 27, 2025

are you sure this is triggered in txpool?

this tx is mined, right? so i think this occurs when populating the rpc fields

@Quertyy
Copy link
Contributor Author

Quertyy commented Jan 27, 2025

Yes you're right, it occurs at the rpc level

@mattsse
Copy link
Collaborator

mattsse commented Jan 27, 2025

I guess for dev mode, the proper fix would really be injecting some fake system tx during block building

@emhane emhane added A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Jan 27, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants