Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move EngineValidator setup to RpcAddOns #11850

Merged
merged 2 commits into from
Oct 19, 2024
Merged

refactor: move EngineValidator setup to RpcAddOns #11850

merged 2 commits into from
Oct 19, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Oct 17, 2024

Closes #11821

Moves EngineValidatorBuilder trait to rpc crate, requiring RpcAddOns to hold one. Removes EngineValidator from types related to node components

@klkvr klkvr changed the title refactor: move EngineValidator setup to addons refactor: move EngineValidator setup to RpcAddOns Oct 17, 2024
@github-actions github-actions bot added A-sdk Related to reth's use as a library C-enhancement New feature or request labels Oct 17, 2024
@klkvr klkvr force-pushed the klkvr/engine-validator-in-rpc branch from ea30fd5 to 0c011cb Compare October 18, 2024 12:09
@mattsse mattsse added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit 2ae9368 Oct 19, 2024
40 checks passed
@mattsse mattsse deleted the klkvr/engine-validator-in-rpc branch October 19, 2024 10:25
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
fix: feature propagation
bb148ad 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

check more features
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
fix: feature propagation
b268f83 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

check more features
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
fix: feature propagation
0971015 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

check more features
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed commit of the following:
90307b6 
commit 1a1aa2f
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <onbjerg@users.noreply.github.com>

commit 3bd695e
Author: Oliver <onbjerg@users.noreply.github.com>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

commit 2ae9368
Author: Arsenii Kulikov <klkvrr@gmail.com>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

commit a4126b3
Author: greged93 <82421016+greged93@users.noreply.github.com>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

commit 655fc1a
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <akinayodeji4all@gmail.com>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed merge of the following commits:
60bf4b7 
commit 1a1aa2f
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <onbjerg@users.noreply.github.com>

commit 3bd695e
Author: Oliver <onbjerg@users.noreply.github.com>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

commit 2ae9368
Author: Arsenii Kulikov <klkvrr@gmail.com>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <82421016+greged93@users.noreply.github.com>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

commit 655fc1a
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <akinayodeji4all@gmail.com>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed merge of the following commits:
aba5cb7 
commit 1a1aa2f
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <onbjerg@users.noreply.github.com>

commit 3bd695e
Author: Oliver <onbjerg@users.noreply.github.com>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

commit 2ae9368
Author: Arsenii Kulikov <klkvrr@gmail.com>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <82421016+greged93@users.noreply.github.com>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

commit 655fc1a
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <akinayodeji4all@gmail.com>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
liamaharon added a commit to liamaharon/reth that referenced this pull request Oct 19, 2024
@liamaharon
Squashed merge of the following commits:
cf94e9e 
commit 1a1aa2f
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <onbjerg@users.noreply.github.com>

commit 3bd695e
Author: Oliver <onbjerg@users.noreply.github.com>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

commit 2ae9368
Author: Arsenii Kulikov <klkvrr@gmail.com>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <82421016+greged93@users.noreply.github.com>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>

commit 655fc1a
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <matthias.seitz@outlook.de>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <akinayodeji4all@gmail.com>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downgrade EngineValidator from component to part of the AddOns
2 participants
@klkvr @mattsse