Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade EngineValidator from component to part of the AddOns #11821

Closed
mattsse opened this issue Oct 16, 2024 · 0 comments · Fixed by #11850
Closed

Downgrade EngineValidator from component to part of the AddOns #11821

mattsse opened this issue Oct 16, 2024 · 0 comments · Fixed by #11850
Assignees
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 16, 2024

Describe the feature

/// Returns the engine validator.
fn engine_validator(&self) -> &Self::EngineValidator;

is only required for launching the engine API

which is as of recently part of the launch_addons function:

node.engine_validator().clone(),

this means we can integrate this into Addons:

for OptimismAddOns<N>

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 16, 2024
@mattsse mattsse self-assigned this Oct 16, 2024
@mattsse mattsse assigned klkvr and unassigned mattsse Oct 17, 2024
@mattsse mattsse added A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants