feat: extend pool configuration #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
greged93
force-pushed
the
feat/pool-config
branch
from
db4b6a9
to
af47bf9
Compare
mattsse
requested changes
Sep 18, 2024
crates/node/core/src/args/txpool.rs
Outdated
Comment on lines
53
to
55
| /// The max gas limit of the block | ||
| #[arg(long = "txpool.block-gas-limit", default_value_t = ETHEREUM_BLOCK_GAS_LIMIT)] | ||
| pub block_gas_limit: u64, |
There was a problem hiding this comment.
this is slightly problematic because we also use this for op,base and I'd like to solve this differently, where do enforce this?
There was a problem hiding this comment.
hmm, this is actually a different problem and we need to make this dynamic based on the newest head.
can we rephrase the docs, so it becomes obvious that this is the default enforced gas limit.
I'm opening an issue for the update
mattsse
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configurable minimal base fee and block gas limit for the pool, which up to now defaulted to
MIN_PROTOCOL_BASE_FEEandETHEREUM_BLOCK_GAS_LIMIT.