Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update txpool max block gas limit #10987

Closed
mattsse opened this issue Sep 18, 2024 · 1 comment · Fixed by #11025
Closed

update txpool max block gas limit #10987

mattsse opened this issue Sep 18, 2024 · 1 comment · Fixed by #11025
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 18, 2024

Describe the feature

currently the block gas limit is fixed

/// The max gas limit of the block
block_gas_limit: u64,

and is used to enforce:

if transaction.gas_limit() > self.block_gas_limit {
return Err(InsertErr::TxGasLimitMoreThanAvailableBlockGas {

we need to update this value to the new tip's gas limit:

/// Hash of the tip block.
pub new_tip: &'a SealedBlock,

when we update the pool:

fn on_canonical_state_change(&self, update: CanonicalStateUpdate<'_>);

@greged93

ref #10985

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled A-tx-pool Related to the transaction mempool and removed S-needs-triage This issue needs to be labelled labels Sep 18, 2024
@greged93
Copy link
Contributor

will work on this next then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants