dev: test vectors seed #10859
Merged
dev: test vectors seed #10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested changes
Sep 12, 2024
| @@ -37,6 +46,7 @@ pub(crate) fn generate_vectors(mut tables: Vec<String>) -> Result<()> { | |||
| tables = all_tables; | |||
| } | |||
|
|
|||
| println!("Seed for test vectors: {:?}", seed); | |||
There was a problem hiding this comment.
let's move this outside of the macro, there is no reason for it to be in here
shekhirin
added
C-test
onbjerg
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a print of the seed for the
reth-dbtest vectors used in the benches.Unfortunately
proptesthides the seed in an internal struct which we don't have access to, so we create a seed ourselves (usinggetrandomas done in proptest) and use this seed for the test.Resolves #10610