-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report seed for failed Proptest tests in CI #10610
Comments
hey @shekhirin I'm down to work on this |
looking into It is then recommended to commit this file in order to avoid regression. We could have the CI open a PR on failing proptests to add the failing seed to the concerned EDIT: ---- tests::test_addition stdout ----
thread 'tests::test_addition' panicked at src/lib.rs:9:13:
This is a panic
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
proptest: Saving this and future failures in redacted/random/proptest-regressions/lib.txt
proptest: If this test was run on a CI system, you may wish to add the following line to your copy of the file. (You may need to create it.)
cc c07c212ae0bd6647204636668dc32ff126dcc474a3bcafbf9e0e42ae55e3afc8
thread 'tests::test_addition' panicked at src/lib.rs:5:5:
Test failed: This is a panic.
minimal failing input: a = 0, b = 0
successes: 0
local rejects: 0
global rejects: 0
|
@greged93 here's a failure that we recently had https://github.com/paradigmxyz/reth/actions/runs/10615954550/job/29425196986 Now that I look deeper into it, I think it's not a proptest failure, but just a benchmark failing due to bad test vectors that were generated with proptest reth/crates/cli/commands/src/test_vectors/tables.rs Lines 82 to 83 in e1a7012
What we should do is to print to stdout the seed that was used to generate test vectors, so we can reproduce the error in benchmarks locally. |
ah got it, will look into getting the seed out of benchmarks |
Describe the feature
If
proptest
fails, we have no insight into how to reproduce the failure. We should report the seed used for the test run.I'm sure there's a native way to do so in
proptest-rs
.Additional context
No response
The text was updated successfully, but these errors were encountered: