Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make js-feature non default #10447

Merged
merged 3 commits into from
Aug 22, 2024
Merged

feat: make js-feature non default #10447

merged 3 commits into from
Aug 22, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Aug 22, 2024 •
edited by mattsse
Loading

closes #10441

onbjerg
onbjerg requested changes Aug 22, 2024
View reviewed changes
crates/rpc/rpc/src/debug.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg changed the title Make js-feature non default feat: make js-feature non default Aug 22, 2024
@onbjerg onbjerg added the C-enhancement New feature or request label Aug 22, 2024
@nkysg nkysg requested a review from onbjerg August 22, 2024 10:46
@onbjerg
Copy link
Member

onbjerg commented Aug 22, 2024

thank you!

@onbjerg onbjerg added this pull request to the merge queue Aug 22, 2024
mattsse
mattsse approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I've enabled js-tracer in rpc-builder now otherwise this would now no longer be enabled when we launch the node

Merged via the queue into paradigmxyz:main with commit 82f1016 Aug 22, 2024
32 checks passed
@nkysg nkysg deleted the js-non-default branch August 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make js-feature non default
3 participants
@nkysg @onbjerg @mattsse