Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make js-feature non default #10441

Closed
mattsse opened this issue Aug 22, 2024 · 3 comments · Fixed by #10447
Closed

Make js-feature non default #10441

mattsse opened this issue Aug 22, 2024 · 3 comments · Fixed by #10447
Assignees
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

Describe the feature

js-tracer is currently always enabled

revm-inspectors = { workspace = true, features = ["js-tracer"] }

we can avoid this by

  1. make this non-default:
    default = ["js-tracer"]
  2. introduce js-tracer feature on rpc that enables:
    revm-inspectors = { workspace = true, features = ["js-tracer"] }
    and feature gate support for js tracer

Additional context

This outlines an alternative solution to what was attempted in #10248

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started A-dependencies Pull requests or issues that are about dependencies and removed S-needs-triage This issue needs to be labelled labels Aug 22, 2024
@nkysg
Copy link
Contributor

nkysg commented Aug 22, 2024

please assign me

@storopoli
Copy link

Thank you!
Can we also make it optional in the node level as well, e.g. in the rpc-builder?

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 22, 2024

we could, we could push it down to node-builder or ethereum/op-node level

I'd appreciate an issue for this and perhaps some context if you can share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants