Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update hive expected failures #10386

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Aug 19, 2024

Removes previously failing tests from expected_failures now that ethereum/hive#1135 is fixed (now that they pass, they cause an Unexpected Passes failure now in hive executions like https://github.com/paradigmxyz/reth/actions/runs/10444795560/job/28920204718)

Copy link
Collaborator

@jenpaff jenpaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fgimenez fgimenez added the C-hivetest Used for labelling automated issues relating to hive test failures label Aug 19, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 9dc855d Aug 19, 2024
37 checks passed
@Rjected Rjected deleted the fgimenez/update-hive-expected-failures branch August 19, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-hivetest Used for labelling automated issues relating to hive test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants