TEST ISSUE in some missing ancestor reorg tests

[Rjected]

When running:

Invalid Missing Ancestor Syncing ReOrg, GasLimit, EmptyTxs=False, CanonicalReOrg=True, Invalid P8

I get:

FAIL (Invalid Missing Ancestor Syncing ReOrg, GasLimit, EmptyTxs=False, CanonicalReOrg=True, Invalid P8): TEST ISSUE - Failed to set invalid block: triedb layer [0x5bb856b70f63d46b95dff7d2b07700194311a87c8a7494ad0de0e72de23d624b] is disk layer

We caught these when testing recent updates to our CI which should improve catching individual test regressions. I'm not really sure how to fix this, but it says TEST ISSUE and fails on reth / geth / erigon, so I assume this is a hive issue.

[Rjected]

just bumping this issue as we are currently rewriting a lot of engine logic, and having coverage from these tests would be great

[marioevz]

Sorry about the delay, taking a look today!

[marioevz]

The problem seems to be in the geth node module we use to simulate a client delivering bad blocks through the p2p network: https://github.com/ethereum/hive/blob/master/simulators/ethereum/engine/client/node/node.go

Since the error suggests that tree leaf could not be modified since it made its way to the disk, I tried modifying the parameters for the database cache to no success:

hive/simulators/ethereum/engine/client/node/node.go

Lines 208 to 209 in 8fd042d

	DatabaseCache: 256,
	DatabaseHandles: 256,

Will keep looking into it.