-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(reth-node-builder): Replace HeadersClient + BodiesClient with BlockClient #10059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested changes
Aug 3, 2024
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
emhane
approved these changes
Aug 3, 2024
recommend using the shortcut command |
Thanks for the tip! And sorry for the multiple review requests, I am new to the repo and rust in general. |
no worries! thanks! hope you find some more issues that look fun to you |
martinezjorge
pushed a commit
to martinezjorge/reth
that referenced
this pull request
Aug 7, 2024
…lockClient (paradigmxyz#10059) Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace HeadersClient + BodiesClient with BlockClient in reth-node-builder. #10053