Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reth-node-builder): Replace HeadersClient + BodiesClient with BlockClient #10059

Merged
merged 5 commits into from
Aug 4, 2024

Conversation

SkandaBhat
Copy link
Contributor

@SkandaBhat SkandaBhat commented Aug 3, 2024

Replace HeadersClient + BodiesClient with BlockClient in reth-node-builder. #10053

crates/node/builder/src/setup.rs Outdated Show resolved Hide resolved
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
@SkandaBhat SkandaBhat requested a review from emhane August 3, 2024 20:02
@emhane
Copy link
Member

emhane commented Aug 3, 2024

recommend using the shortcut command make lint @SkandaBhat

@SkandaBhat SkandaBhat requested a review from emhane August 4, 2024 09:34
@SkandaBhat
Copy link
Contributor Author

recommend using the shortcut command make lint @SkandaBhat

Thanks for the tip! And sorry for the multiple review requests, I am new to the repo and rust in general.

@emhane
Copy link
Member

emhane commented Aug 4, 2024

Thanks for the tip! And sorry for the multiple review requests, I am new to the repo and rust in general.

no worries! thanks! hope you find some more issues that look fun to you

@emhane emhane enabled auto-merge August 4, 2024 15:33
@emhane emhane added this pull request to the merge queue Aug 4, 2024
Merged via the queue into paradigmxyz:main with commit a824735 Aug 4, 2024
32 checks passed
@SkandaBhat SkandaBhat deleted the BlockClient branch August 4, 2024 17:52
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
…lockClient (paradigmxyz#10059)

Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants