Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(reth-network-p2p): Replace HeadersClient + BodiesClient with BlockClient #10058

Merged
merged 4 commits into from
Aug 4, 2024
Merged

chore(reth-network-p2p): Replace HeadersClient + BodiesClient with BlockClient #10058

merged 4 commits into from
Aug 4, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Aug 3, 2024 •
edited
Loading

Partly towards #10053

emhane
emhane requested changes Aug 3, 2024
View reviewed changes
crates/net/p2p/src/lib.rs Outdated Show resolved Hide resolved
mattsse
mattsse reviewed Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

crates/net/p2p/src/lib.rs Outdated Show resolved Hide resolved
crates/net/p2p/src/lib.rs Outdated

impl<T> BlockClient for T where T: HeadersClient + BodiesClient + Unpin + Clone {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nkysg nkysg requested a review from rkrasiuk as a code owner August 4, 2024 02:14
@nkysg nkysg requested review from emhane and mattsse August 4, 2024 02:17
@nkysg @SkandaBhat
Update crates/net/p2p/src/full_block.rs
f17d98c 
Co-authored-by: Skanda Bhat <bhat.skanda.m@gmail.com>
@emhane emhane added this pull request to the merge queue Aug 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2024
@nkysg
Copy link
Contributor Author

nkysg commented Aug 4, 2024

It seems that https://github.com/paradigmxyz/reth/actions/runs/10237390617/job/28320622433 fail. Do you know why? @emhane @mattsse

@emhane emhane added this pull request to the merge queue Aug 4, 2024
Merged via the queue into paradigmxyz:main with commit 9c80cc4 Aug 4, 2024
32 checks passed
@nkysg nkysg deleted the BlockClient_p2p branch August 4, 2024 16:40
@emhane
Copy link
Member

emhane commented Aug 4, 2024

not sure why the test fails, will open an issue for flaky test

martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@nkysg @SkandaBhat @martinezjorge
chore(reth-network-p2p): Replace HeadersClient + BodiesClient with Bl…
099b9ac 
…ockClient (paradigmxyz#10058)

Co-authored-by: Skanda Bhat <bhat.skanda.m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkandaBhat SkandaBhat SkandaBhat left review comments

@emhane emhane emhane approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkysg @emhane @SkandaBhat @mattsse