Partially type check help, ivy, task, and backend target and subsystem folders

src/python/pants/backend/codegen/thrift/java/BUILD

@@ -13,4 +13,5 @@ python_library(
     'src/python/pants/subsystem',
     'src/python/pants/task',
   ],
+  tags = {"partially_type_checked"},
 )

src/python/pants/backend/codegen/thrift/lib/BUILD

@@ -11,4 +11,5 @@ python_library(
     'src/python/pants/task',
     'src/python/pants/util:memo',
   ],
+  tags = {"partially_type_checked"},
 )

src/python/pants/backend/codegen/thrift/lib/apache_thrift_gen_base.py

@@ -5,6 +5,7 @@
 import re
 import shutil
 import subprocess
+from typing import Optional
 
 from twitter.common.collections import OrderedSet
 
@@ -20,7 +21,7 @@
 class ApacheThriftGenBase(SimpleCodegenTask):
   # The name of the thrift generator to use. Subclasses must set.
   # E.g., java, py (see `thrift -help` for all available generators).
-  thrift_generator = None
+  thrift_generator: Optional[str] = None
 
   # Subclasses may set their own default generator options.
   default_gen_options_map = None

src/python/pants/backend/graph_info/subsystems/cloc_binary.py

@@ -12,4 +12,3 @@ class ClocBinary(Script):
 
   replaces_scope = 'cloc'
   replaces_name = 'version'
-

src/python/pants/backend/jvm/BUILD

@@ -7,7 +7,8 @@ python_library(
   dependencies=[
     'src/python/pants/util:contextutil',
     'src/python/pants/util:dirutil',
-  ]
+  ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -18,6 +19,7 @@ python_library(
     'src/python/pants/base:hash_utils',
     'src/python/pants/base:payload_field',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -59,6 +61,7 @@ python_library(
     'src/python/pants/util:dirutil',
     'src/python/pants/util:fileutil',
   ],
+  tags = {"partially_type_checked"},
 )
 
 resources(
@@ -69,8 +72,7 @@ resources(
 python_library(
   name='repository',
   sources=['repository.py'],
-  dependencies = [
-  ]
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -90,4 +92,5 @@ python_library(
     ':artifact',
     'src/python/pants/base:validation',
   ],
+  tags = {"partially_type_checked"},
 )

src/python/pants/backend/jvm/ivy_utils.py

@@ -796,7 +796,7 @@ def _exec_ivy(cls, ivy, confs, ivyxml, args, jvm_options, executor,
 
     runner = ivy.runner(jvm_options=ivy_jvm_options, args=ivy_args, executor=executor)
     try:
-      with ivy.resolution_lock:
+      with ivy.resolution_lock():
         result = execute_runner(runner, workunit_factory=workunit_factory,
                                 workunit_name=workunit_name)
       if result != 0:

src/python/pants/backend/jvm/subsystems/BUILD

@@ -22,6 +22,7 @@ python_library(
     'src/python/pants/java/distribution',
     'src/python/pants/option',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -34,6 +35,7 @@ python_library(
     'src/python/pants/option',
     'src/python/pants/subsystem',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -46,6 +48,7 @@ python_library(
     'src/python/pants/option',
     'src/python/pants/subsystem',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -59,6 +62,7 @@ python_library(
     'src/python/pants/build_graph',
     'src/python/pants/subsystem',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -69,6 +73,7 @@ python_library(
     'src/python/pants/subsystem',
     'src/python/pants/util:strutil',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -82,6 +87,7 @@ python_library(
     'src/python/pants/util:memo',
     'src/python/pants/java/distribution',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -109,6 +115,7 @@ python_library(
     'src/python/pants/backend/jvm/targets:jvm',
     'src/python/pants/util:memo',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -120,6 +127,7 @@ python_library(
     'src/python/pants/java/jar',
     'src/python/pants/backend/jvm/targets:jvm',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -133,7 +141,8 @@ python_library(
     'src/python/pants/java/jar',
     'src/python/pants/subsystem',
     'src/python/pants/util:contextutil',
-  ]
+  ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -154,7 +163,8 @@ python_library(
   dependencies = [
     'src/python/pants/build_graph',
     'src/python/pants/subsystem',
-  ]
+  ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(

src/python/pants/backend/jvm/subsystems/jvm_tool_mixin.py

@@ -3,6 +3,7 @@
 
 from collections import namedtuple
 from textwrap import dedent
+from typing import List
 
 from pants.base.exceptions import TaskError
 from pants.java.distribution.distribution import DistributionLocator
@@ -46,7 +47,7 @@ def is_default(self, options):
       """
       return options.for_scope(self.scope).is_default(self.key.replace('-', '_'))
 
-  _jvm_tools = []  # List of JvmTool objects.
+  _jvm_tools: List[JvmTool] = []
 
   @classmethod
   def subsystem_dependencies(cls):
@@ -147,15 +148,12 @@ def prepare_tools(cls, round_manager):
     round_manager.require_data('jvm_build_tools_classpath_callbacks')
 
   @staticmethod
-  def get_registered_tools():
-    """Returns all registered jvm tools.
-
-    :rtype: list of :class:`JvmToolMixin.JvmTool`
-    """
+  def get_registered_tools() -> List["JvmTool"]:
+    """Returns all registered jvm tools."""
     return JvmToolMixin._jvm_tools
 
   @staticmethod
-  def reset_registered_tools():
+  def reset_registered_tools() -> None:
     """Needed only for test isolation."""
     JvmToolMixin._jvm_tools = []
 

src/python/pants/backend/jvm/targets/BUILD

@@ -46,6 +46,7 @@ python_library(
     'src/python/pants/util:netrc',
     'src/python/pants/util:objects',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -64,6 +65,7 @@ python_library(
     'src/python/pants/base:exceptions',
     'src/python/pants/build_graph',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -85,4 +87,5 @@ python_library(
     'src/python/pants/build_graph',
     'src/python/pants/util:memo',
   ],
+  tags = {"partially_type_checked"},
 )

src/python/pants/backend/jvm/targets/jvm_prep_command.py

@@ -1,6 +1,8 @@
 # Copyright 2015 Pants project contributors (see CONTRIBUTORS.md).
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
 
+from typing import FrozenSet
+
 from pants.backend.jvm.targets.jvm_target import JvmTarget
 from pants.base.exceptions import TargetDefinitionException
 from pants.base.payload import Payload
@@ -34,20 +36,20 @@ class JvmPrepCommand(JvmTarget):
 
   :API: public
   """
-  _goals=frozenset()
+  _goals: FrozenSet[str] = frozenset()
 
   @staticmethod
   def add_goal(goal):
     """Add a named goal to the list of valid goals for the 'goal' parameter."""
     JvmPrepCommand._goals = frozenset(list(JvmPrepCommand._goals) + [goal])
 
   @classmethod
-  def reset(cls):
+  def reset(cls) -> None:
     """Used for testing purposes to reset state."""
-    cls._goals=frozenset()
+    cls._goals = frozenset()
 
   @staticmethod
-  def goals():
+  def goals() -> FrozenSet[str]:
     return JvmPrepCommand._goals
 
   def __init__(self, payload=None, mainclass=None, args=None, jvm_options=None, goal=None,

src/python/pants/backend/jvm/tasks/BUILD

@@ -165,6 +165,7 @@ python_library(
 python_library(
   name = 'classpath_entry',
   sources = ['classpath_entry.py'],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -177,6 +178,7 @@ python_library(
     'src/python/pants/util:dirutil',
     'src/python/pants/util:strutil',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -193,6 +195,7 @@ python_library(
     'src/python/pants/goal:products',
     'src/python/pants/util:dirutil',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -517,6 +520,7 @@ python_library(
     'src/python/pants/base:exceptions',
     'src/python/pants/task',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(
@@ -547,6 +551,7 @@ python_library(
     'src/python/pants/process',
     'src/python/pants/task',
   ],
+  tags = {"partially_type_checked"},
 )
 
 python_library(

src/python/pants/backend/jvm/tasks/coursier/coursier_subsystem.py

@@ -68,7 +68,7 @@ def get_external_url_generator(self):
 class CoursierUrlGenerator(BinaryToolUrlGenerator):
 
   def __init__(self, template_urls):
-    super(CoursierUrlGenerator, self).__init__()
+    super().__init__()
     self._template_urls = template_urls
 
   def generate_urls(self, version, host_platform):

src/python/pants/backend/native/config/BUILD

@@ -7,4 +7,5 @@ python_library(
     'src/python/pants/engine:platform',
     'src/python/pants/util:osutil',
   ],
+  tags = {"partially_type_checked"},
 )

src/python/pants/backend/native/config/environment.py

@@ -47,9 +47,9 @@ def _single_list_field_operation(self, field_name, list_value, prepend=True):
     cur_value = getattr(self, field_name)
 
     if prepend:
-      new_value = list_value + cur_value
+      new_value = tuple(list_value) + tuple(cur_value)
     else:
-      new_value = cur_value + list_value
+      new_value = tuple(cur_value) + tuple(list_value)
 
     arg_dict = {field_name: new_value}
     return self.copy(**arg_dict)
@@ -93,7 +93,7 @@ def sequence(self, other, exclude_list_fields=None):
     for list_field_name in shared_list_fields:
       lhs_value = getattr(self, list_field_name)
       rhs_value = getattr(other, list_field_name)
-      overwrite_kwargs[list_field_name] = lhs_value + rhs_value
+      overwrite_kwargs[list_field_name] = tuple(lhs_value) + tuple(rhs_value)
 
     return self.copy(**overwrite_kwargs)
 
@@ -187,7 +187,7 @@ class Assembler(_AlgebraicDataclass, _Executable):
   path_entries: Tuple[str, ...]
   exe_filename: str
   runtime_library_dirs: Tuple[str, ...]
-  extra_args: Tuple[str]
+  extra_args: Tuple[str, ...]
 
 
 class _LinkerMixin(_Executable):
@@ -212,7 +212,7 @@ def extra_object_files(self):
   def invocation_environment_dict(self):
     ret = super(_LinkerMixin, self).invocation_environment_dict.copy()
 
-    full_library_path_dirs = self.linking_library_dirs + [
+    full_library_path_dirs = list(self.linking_library_dirs) + [
       os.path.dirname(f) for f in self.extra_object_files
     ]
 

src/python/pants/backend/native/subsystems/BUILD

@@ -9,6 +9,7 @@ python_library(
     'src/python/pants/backend/native/subsystems/utils',
     'src/python/pants/build_graph',
     'src/python/pants/engine:rules',
+    'src/python/pants/engine:platform',
     'src/python/pants/engine:selectors',
     'src/python/pants/subsystem',
     'src/python/pants/util:collections',

src/python/pants/backend/native/subsystems/binaries/BUILD

@@ -8,7 +8,9 @@ python_library(
     'src/python/pants/backend/native/subsystems/utils',
     'src/python/pants/binaries',
     'src/python/pants/engine:rules',
+    'src/python/pants/engine:platform',
     'src/python/pants/util:dirutil',
     'src/python/pants/util:memo',
   ],
+  tags = {"partially_type_checked"},
 )