Partially type check help, ivy, task, and backend target and subsystem folders

[Eric-Arellano]

As with prior PRs, the focus is on getting as many targets passing with partially_type_checked as possible, rather than adding comprehensive type checks at this stage.

[Eric-Arellano]

See https://docs.google.com/spreadsheets/d/1MKg82Fs3uIMOZDoWeNUBD-VirVkOzHU8Tte7oY6ypP0/edit#gid=1479336346 for the current status. The biggest blocker now is that @rules are typed to return a type, but MyPy wants them to be wrapped in Iterator or Generator. I'll look more into this.

[cosmicexplorer]

Thank you!!

[cosmicexplorer]

Thank you for fixing this!! Could you please add a TODO here pointing to #5663 and mentioning that this is currently dead code? Sorry for not doing this myself!!

[cosmicexplorer]

Is this necessary for typechecking, or is it a style change? I'm very fine with it either way.

[Eric-Arellano]

Necessary for type checking. Apparently it's bad to use @property and @contextmanager on the same function. MyPy complains about doing that.

[cosmicexplorer]

I believe the following diff should fix the CI failure:

diff --git a/src/python/pants/backend/native/config/environment.py b/src/python/pants/backend/native/config/environment.py
index 811eeaf29..5b0d04aa2 100644
--- a/src/python/pants/backend/native/config/environment.py
+++ b/src/python/pants/backend/native/config/environment.py
@@ -47,9 +47,9 @@ class _ExtensibleAlgebraic(ABC):
     cur_value = getattr(self, field_name)

     if prepend:
-      new_value = list_value + cur_value
+      new_value = tuple(list_value) + tuple(cur_value)
     else:
-      new_value = cur_value + list_value
+      new_value = tuple(cur_value) + tuple(list_value)

     arg_dict = {field_name: new_value}
     return self.copy(**arg_dict)
@@ -93,7 +93,7 @@ class _ExtensibleAlgebraic(ABC):
     for list_field_name in shared_list_fields:
       lhs_value = getattr(self, list_field_name)
       rhs_value = getattr(other, list_field_name)
-      overwrite_kwargs[list_field_name] = lhs_value + rhs_value
+      overwrite_kwargs[list_field_name] = tuple(lhs_value) + tuple(rhs_value)

     return self.copy(**overwrite_kwargs)

@@ -212,7 +212,7 @@ class _LinkerMixin(_Executable):
   def invocation_environment_dict(self):
     ret = super(_LinkerMixin, self).invocation_environment_dict.copy()

-    full_library_path_dirs = self.linking_library_dirs + [
+    full_library_path_dirs = list(self.linking_library_dirs) + [
       os.path.dirname(f) for f in self.extra_object_files
     ]

diff --git a/src/python/pants/backend/native/tasks/link_shared_libraries.py b/src/python/pants/backend/native/tasks/link_shared_libraries.py
index 72a32d4fa..85a16c368 100644
--- a/src/python/pants/backend/native/tasks/link_shared_libraries.py
+++ b/src/python/pants/backend/native/tasks/link_shared_libraries.py
@@ -169,7 +169,7 @@ class LinkSharedLibraries(NativeTask):
       self.platform.match(
         {Platform.darwin: ['-Wl,-dylib'], Platform.linux: ['-shared']}
       ) +
-      linker.extra_args +
+      list(linker.extra_args) +
       ['-o', os.path.abspath(resulting_shared_lib_path)] +
       ['-L{}'.format(lib_dir) for lib_dir in link_request.external_lib_dirs] +
       ['-l{}'.format(lib_name) for lib_name in link_request.external_lib_names] +
diff --git a/src/python/pants/backend/native/tasks/native_compile.py b/src/python/pants/backend/native/tasks/native_compile.py
index 13abecae6..1a5665845 100644
--- a/src/python/pants/backend/native/tasks/native_compile.py
+++ b/src/python/pants/backend/native/tasks/native_compile.py
@@ -208,10 +208,10 @@ class NativeCompile(NativeTask, metaclass=ABCMeta):
     # TODO: add -v to every compiler and linker invocation!
     argv = (
       [compiler.exe_filename] +
-      compiler.extra_args +
+      list(compiler.extra_args) +
       # TODO: If we need to produce static libs, don't add -fPIC! (could use Variants -- see #5788).
       ['-c', '-fPIC'] +
-      compiler_options +
+      list(compiler_options) +
       [
         '-I{}'.format(os.path.join(buildroot, inc_dir))
         for inc_dir in compile_request.include_dirs

[cosmicexplorer]

One last time should do the trick!! Sorry for not checking the subsystem tests too!

diff --git a/tests/python/pants_test/backend/native/subsystems/test_native_toolchain.py b/tests/python/pants_test/backend/native/subsystems/test_native_toolchain.py
index 758d4c6a3..a1308a12f 100644
--- a/tests/python/pants_test/backend/native/subsystems/test_native_toolchain.py
+++ b/tests/python/pants_test/backend/native/subsystems/test_native_toolchain.py
@@ -121,7 +121,7 @@ class TestNativeToolchain(TestBase, SchedulerTestBase):
         yield toolchain

   def _invoke_compiler(self, compiler, args):
-    cmd = [compiler.exe_filename] + compiler.extra_args + args
+    cmd = [compiler.exe_filename] + list(compiler.extra_args) + args
     env = compiler.invocation_environment_dict
     # TODO: add an `extra_args`-like field to `Executable`s which allows for overriding env vars
     # like this, but declaratively!
@@ -129,7 +129,7 @@ class TestNativeToolchain(TestBase, SchedulerTestBase):
     return self._invoke_capturing_output(cmd, env)

   def _invoke_linker(self, linker, args):
-    cmd = [linker.exe_filename] + linker.extra_args + args
+    cmd = [linker.exe_filename] + list(linker.extra_args) + args
     return self._invoke_capturing_output(
       cmd,
       linker.invocation_environment_dict)