Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SelectInterpreter read of interpreter.path #5925

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jun 7, 2018

Since SelectInterpreter does not use results dirs, we change the
interpreter.path file whose format has changed to be
interpreter.info.

Since `SelectInterpreter` does not use results dirs, we change the
`interpreter.path` file whose format has changed to be
`interpreter.info`.
@jsirois jsirois requested a review from illicitonion June 7, 2018 12:34
@jsirois jsirois mentioned this pull request Jun 7, 2018
Copy link
Contributor

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp :)

@jsirois
Copy link
Contributor Author

jsirois commented Jun 7, 2018

Getting CI green is tough today. Many shard re-starts due to networking issues on Travis CI. I'll be back online in ~2 hours (12:30pm Mountain Time) to check in on this, but if someone wants to merge ahead of that, feel free.

@jsirois jsirois merged commit 67a2b59 into pantsbuild:master Jun 7, 2018
@jsirois jsirois deleted the issues/5906-follow-up-fix branch June 7, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants