-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pex 1.4.3. #5910
Upgrade to pex 1.4.3. #5910
Conversation
a9c8f17
to
41b8a73
Compare
This hacks around a few issues with the 1.4.x pex API. We concoct a minimal local `Platform` to pass to `resolve` where a local interpreter is passed to work around pex-tool/pex#511. We also now consolidate `PythonInterpreter` construction in production code to helper that ensures the interpreters we create are bare (isolated) except for the specific extras we require to work around pex-tool/pex#510. Upgrading pex to take advantage of the worked around issues noted above is tracked by pantsbuild#5922. Fixes pantsbuild#5906
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks John! lgtm!
This broke my pants at HEAD:
|
Hrm. The version bump in the task was meant to cover the interpreter file format change. I'll followup here presently. Sorry for the breakage! |
@illicitonion you probably figured this out but the workaround is a |
Fix in #5925 |
Thanks for the quick fix! |
This hacks around a few issues with the 1.4.x pex API. We concoct a
minimal local
Platform
to pass toresolve
where a local interpreteris passed to work around pex-tool/pex#511.
We also now consolidate
PythonInterpreter
construction in productioncode to helper that ensures the interpreters we create are bare
(isolated) except for the specific extras we require to work around
pex-tool/pex#510.
Upgrading pex to take advantage of the worked around issues noted above
is tracked by #5922.
Fixes #5906