Robustify SetupPyIntegrationTest.
#5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the pants `VERSION` was bumped and before publishing the `test_setup_py_unregistered_pants_plugin` test would fail to resolve `pantsbuild.pants` at the new version on pypi. Update the test to use a custom-produced `pantsbuild.pants` distribution and share this logic with `PantsRequirementIntegrationTest`. Similar to pantsbuild#5519
|
I'm going to TBR this to unblock the release over in #5607 |
stuhood
pushed a commit
that referenced
this pull request
Apr 5, 2018
### Problem These tests were previously stabilized by running against private publishes in #5610 and #5520. But because they were still covered by `TestProjectsIntegrationTest` (outside the context of the private publish), they failed there instead. ### Solution Ban them from `TestProjectsIntegrationTest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the pants
VERSIONwas bumped and before publishingthe
test_setup_py_unregistered_pants_plugintest would fail to resolvepantsbuild.pantsat the new version on pypi. Update the test to use acustom-produced
pantsbuild.pantsdistribution and share this logicwith
PantsRequirementIntegrationTest.Similar to #5519 / #5520