Robustify PantsRequirementIntegrationTest.
#5520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously changes to `pantsbuild.pants` requirements on master between releases would lead to resolution conflicts in the `test_pants_requirement` test. Make the test robust to these sort of changes by producing and consuming a unique `pantsbuild.pants` distribution for each run of the test. Fixes pantsbuild#5519
|
Sorry about this. Thanks for fixing. |
stuhood
approved these changes
Feb 26, 2018
This was referenced Mar 17, 2018
stuhood
pushed a commit
that referenced
this pull request
Apr 5, 2018
### Problem These tests were previously stabilized by running against private publishes in #5610 and #5520. But because they were still covered by `TestProjectsIntegrationTest` (outside the context of the private publish), they failed there instead. ### Solution Ban them from `TestProjectsIntegrationTest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously changes to
pantsbuild.pantsrequirements on master betweenreleases would lead to resolution conflicts in the
test_pants_requirementtest. Make the test robust to these sort ofchanges by producing and consuming a unique
pantsbuild.pantsdistribution for each run of the test.
Fixes #5519