Minimize classpath pants passes to java for running tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We solved the classpath length issue in a different way: by using relative paths for jar files. It's not quite as complete a solution as this, but it does work for now. Shall we close this, or do you think it is still worth doing? |
WamBamBoozle
pushed a commit
to WamBamBoozle/pants
that referenced
this pull request
Apr 23, 2015
In minor releases we guarantee binary compatibility but c7ec312 slipped through the cracks. This change fixes the breakage introduced in c7ec312. Fixes pantsbuild#44.
WamBamBoozle
pushed a commit
to WamBamBoozle/pants
that referenced
this pull request
Apr 23, 2015
The `Inputs.create` method has been modified by 60c7e4d to add support for IncOptions. That broke both binary and source compatibility. Let's restore the old signature for Inputs.create and deprecate it at the same time. Fixes another instance of pantsbuild#44.
digwanderlust
added a commit
to digwanderlust/pants
that referenced
this pull request
Jul 1, 2016
1.1.0-rc0 (7/1/2016)
--------------------
This is the first `1.1.0-rc` release on the way to the `1.1.0`.
New Features
~~~~~~~~~~~~
* Subprocess clean-all
`RB pantsbuild#4011 <https://rbcommons.com/s/twitter/r/4011>`_
* expose products for jvm bundle create and python binary create tasks
`RB pantsbuild#3959 <https://rbcommons.com/s/twitter/r/3959>`_
`RB pantsbuild#4015 <https://rbcommons.com/s/twitter/r/4015>`_
* Implement zinc `unused deps` check
`RB pantsbuild#3635 <https://rbcommons.com/s/twitter/r/3635>`_
API Changes
~~~~~~~~~~~
* Add `is_target_root` in export
`RB pantsbuild#4030 <https://rbcommons.com/s/twitter/r/4030>`_
Bugfixes
~~~~~~~~
* ConsoleRunner bugfix for @TestSerial and other test cleanups
`RB pantsbuild#4026 <https://rbcommons.com/s/twitter/r/4026>`_
New Engine Work
~~~~~~~~~~~~~~~
* [engine] Proper implementation of `**` globs in the v2 engine
`RB pantsbuild#4034 <https://rbcommons.com/s/twitter/r/4034>`_
* [engine] Fix TargetMacro replacements of adapted aliases
`Issue pantsbuild#3560 <https://github.com/pantsbuild/pants/issues/3560>`_
`Issue pantsbuild#3561 <https://github.com/pantsbuild/pants/issues/3561>`_
`RB pantsbuild#4000 <https://rbcommons.com/s/twitter/r/4000>`_
Refactoring, Improvements, and Tooling
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Fix dead apidocs link for guava.
`RB pantsbuild#4037 <https://rbcommons.com/s/twitter/r/4037>`_
* Bump setproctitle to 1.1.10.
`Issue pantsbuild#44 <https://github.com/dvarrazzo/py-setproctitle/issues/44>`_
`RB pantsbuild#4035 <https://rbcommons.com/s/twitter/r/4035>`_
* Set a default read timeout for fetching node pre-installed modules. 1 second default often fails
`RB pantsbuild#4025 <https://rbcommons.com/s/twitter/r/4025>`_
* Improve stderr handling for ProcessManager.get_subprocess_output().
`RB pantsbuild#4019 <https://rbcommons.com/s/twitter/r/4019>`_
* Add AnnotatedParallelClassesAndMethodsTest* and AnnotatedParallelMethodsTest*
`RB pantsbuild#4027 <https://rbcommons.com/s/twitter/r/4027>`_
digwanderlust
added a commit
to digwanderlust/pants
that referenced
this pull request
Jul 1, 2016
1.1.0-rc0 (7/1/2016)
--------------------
This is the first `1.1.0-rc` release on the way to the `1.1.0`.
New Features
~~~~~~~~~~~~
* Subprocess clean-all
`RB pantsbuild#4011 <https://rbcommons.com/s/twitter/r/4011>`_
* expose products for jvm bundle create and python binary create tasks
`RB pantsbuild#3959 <https://rbcommons.com/s/twitter/r/3959>`_
`RB pantsbuild#4015 <https://rbcommons.com/s/twitter/r/4015>`_
* Implement zinc `unused deps` check
`RB pantsbuild#3635 <https://rbcommons.com/s/twitter/r/3635>`_
API Changes
~~~~~~~~~~~
* Add `is_target_root` in export
`RB pantsbuild#4030 <https://rbcommons.com/s/twitter/r/4030>`_
Bugfixes
~~~~~~~~
* ConsoleRunner bugfix for @TestSerial and other test cleanups
`RB pantsbuild#4026 <https://rbcommons.com/s/twitter/r/4026>`_
New Engine Work
~~~~~~~~~~~~~~~
* [engine] Proper implementation of `**` globs in the v2 engine
`RB pantsbuild#4034 <https://rbcommons.com/s/twitter/r/4034>`_
* [engine] Fix TargetMacro replacements of adapted aliases
`Issue pantsbuild#3560 <https://github.com/pantsbuild/pants/issues/3560>`_
`Issue pantsbuild#3561 <https://github.com/pantsbuild/pants/issues/3561>`_
`RB pantsbuild#4000 <https://rbcommons.com/s/twitter/r/4000>`_
Refactoring, Improvements, and Tooling
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Fix dead apidocs link for guava.
`RB pantsbuild#4037 <https://rbcommons.com/s/twitter/r/4037>`_
* Bump setproctitle to 1.1.10.
`Issue pantsbuild#44 <https://github.com/dvarrazzo/py-setproctitle/issues/44>`_
`RB pantsbuild#4035 <https://rbcommons.com/s/twitter/r/4035>`_
* Set a default read timeout for fetching node pre-installed modules. 1 second default often fails
`RB pantsbuild#4025 <https://rbcommons.com/s/twitter/r/4025>`_
* Improve stderr handling for ProcessManager.get_subprocess_output().
`RB pantsbuild#4019 <https://rbcommons.com/s/twitter/r/4019>`_
* Add AnnotatedParallelClassesAndMethodsTest* and AnnotatedParallelMethodsTest*
`RB pantsbuild#4027 <https://rbcommons.com/s/twitter/r/4027>`_
Testing Done:
CI pending: https://travis-ci.org/pantsbuild/pants/builds/141717353
Bugs closed: 3620
Reviewed at https://rbcommons.com/s/twitter/r/4042/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change decreases the size of the classpath pants passes to java for running tests. It is necessary because this classpath can grow very large, and exceed the maximum argument length on some environments.
Really the best place for this change was in executor.py:Executor:_create_command
But the proper solution would involve changing self._command to a function that returned a context manager (since a temporary jar would need to be created to be used for the new classpath) and this would require refactoring a considerable amount of code.
This fix is also a bandaid fix, as it does not ultimately solve the classpath length problem (it only removes jars from the classpath).
Because of the fact that this fix is hopefully temporary, and a refactor now would require another refactor when a better solution is implemented, I instead opted to make the classpath change in the client code rather than in the lower level java executor code.
I did not add tests/logging because I did not find any existing tests/logging in the source (it would also probably require heavy mocking). If you think the code needs some please let me know and I'll add it.