Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shading cobertura jars to get rid of the logging jar conflict with opinionated frameworks like dropwizard #3635

Conversation

manasapte
Copy link

I have tested this on a local sample dropwizard project and it works.

mateor pushed a commit to foursquare/pants that referenced this pull request Jul 8, 2016
1.1.0-rc0 (7/1/2016)
  --------------------

  This is the first `1.1.0-rc` release on the way to the `1.1.0`.

  New Features
  ~~~~~~~~~~~~

  * Subprocess clean-all
    `RB pantsbuild#4011 <https://rbcommons.com/s/twitter/r/4011>`_

  * expose products for jvm bundle create and python binary create tasks
    `RB pantsbuild#3959 <https://rbcommons.com/s/twitter/r/3959>`_
    `RB pantsbuild#4015 <https://rbcommons.com/s/twitter/r/4015>`_

  * Implement zinc `unused deps` check
    `RB pantsbuild#3635 <https://rbcommons.com/s/twitter/r/3635>`_

  API Changes
  ~~~~~~~~~~~

  * Add `is_target_root` in export
    `RB pantsbuild#4030 <https://rbcommons.com/s/twitter/r/4030>`_

  Bugfixes
  ~~~~~~~~

  * ConsoleRunner bugfix for @TestSerial and other test cleanups
    `RB pantsbuild#4026 <https://rbcommons.com/s/twitter/r/4026>`_

  New Engine Work
  ~~~~~~~~~~~~~~~

  * [engine] Proper implementation of `**` globs in the v2 engine
    `RB pantsbuild#4034 <https://rbcommons.com/s/twitter/r/4034>`_

  * [engine] Fix TargetMacro replacements of adapted aliases
    `Issue pantsbuild#3560 <https://github.com/pantsbuild/pants/issues/3560>`_
    `Issue pantsbuild#3561 <https://github.com/pantsbuild/pants/issues/3561>`_
    `RB pantsbuild#4000 <https://rbcommons.com/s/twitter/r/4000>`_

  Refactoring, Improvements, and Tooling
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  * Fix dead apidocs link for guava.
    `RB pantsbuild#4037 <https://rbcommons.com/s/twitter/r/4037>`_

  * Bump setproctitle to 1.1.10.
    `Issue #44 <https://github.com/dvarrazzo/py-setproctitle/issues/44>`_
    `RB pantsbuild#4035 <https://rbcommons.com/s/twitter/r/4035>`_

  * Set a default read timeout for fetching node pre-installed modules. 1 second default often fails
    `RB pantsbuild#4025 <https://rbcommons.com/s/twitter/r/4025>`_

  * Improve stderr handling for ProcessManager.get_subprocess_output().
    `RB pantsbuild#4019 <https://rbcommons.com/s/twitter/r/4019>`_

  * Add AnnotatedParallelClassesAndMethodsTest* and AnnotatedParallelMethodsTest*
    `RB pantsbuild#4027 <https://rbcommons.com/s/twitter/r/4027>`_

Testing Done:
CI pending: https://travis-ci.org/pantsbuild/pants/builds/141717353

Bugs closed: 3620

Reviewed at https://rbcommons.com/s/twitter/r/4042/
@manasapte manasapte force-pushed the manasapte/3632_cobertura-dropwizard-logging-conflict branch from 56758c7 to e8d5ec1 Compare July 12, 2016 20:20
@manasapte manasapte force-pushed the manasapte/3632_cobertura-dropwizard-logging-conflict branch from e8d5ec1 to f9614a2 Compare July 13, 2016 04:33
@jsirois
Copy link
Contributor

jsirois commented Apr 18, 2017

Closing this since it looks like a PR in the same spirit was presented in #4198 and merged @ d95447f

@jsirois jsirois closed this Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants