Upgrade to fixed rust-cache action. #21589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
added
needs-cherrypick
category:internal
huonw
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks.
Preserving the slack discussion for context: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1730098922404299
when I rebased my patch onto a later version of the upstream action, I screwed up handling the compiled js, so it had basically reverted to the pre-patch state. Now I have regenerated it from scratch (which is what I should have done all along)
|
I will add a README to my patch, so we know how to build the .js in the future. Also, I have submitted this as a PR upstream, which would be even better: Swatinem/rust-cache#216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous one had a regression in the compiled .js files.