Allow opting out of caching $CARGO_HOME/bin. #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents wiping the bin directory, which is harmful for self-hosted runners.
Swatinem
approved these changes
Dec 8, 2024
Fix a few whitespace nits.
This was done with: `ncc build --target es2020 -o dist/restore src/restore.ts && ncc build --target es2020 -o dist/save src/save.ts && linefix dist` Which I hope is correct.
|
Thanks for the review! I tweaked slightly, handled the merge conflict, and regenerated the files under
Is that correct? |
|
That didn’t seem to have been correct. |
This reverts commit 19dc6a9.
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents wiping the bin directory, which is harmful
on long-lived self-hosted runners, as it will nuke
rustup, rustc, cargo and so on.