Skip to content

Commit

Permalink
specify mypy lint tag name and add default tag in pants.ini
Browse files Browse the repository at this point in the history
  • Loading branch information
Mohamed Abdi committed Jul 30, 2019
1 parent b45a94d commit dff9175
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion build-support/githooks/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ if git rev-parse --verify "${MERGE_BASE}" &>/dev/null; then
# TODO: add a test case for this while including a pexrc file, as python checkstyle currently fails
# quite often with a pexrc available.
echo "* Checking lint"
./pants --whitelist-tag-name=type_checked --exclude-target-regexp='testprojects/.*' --changed-parent="${MERGE_BASE}" lint || exit 1
./pants --lint-mypy-whitelist-tag-name=type_checked --exclude-target-regexp='testprojects/.*' --changed-parent="${MERGE_BASE}" lint || exit 1

if git diff "${MERGE_BASE}" --name-only | grep '\.rs$' > /dev/null; then
echo "* Checking formatting of rust files"
Expand Down
1 change: 1 addition & 0 deletions pants.ini
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ skip: True
skip: True

[lint.mypy]
whitelist_tag_name = type_checked
config_file: build-support/mypy/mypy.ini

[scala]
Expand Down

0 comments on commit dff9175

Please sign in to comment.