Skip to content

Commit

Permalink
move ci mypy check to be under lint
Browse files Browse the repository at this point in the history
  • Loading branch information
Mohamed Abdi committed Jul 30, 2019
1 parent 0cb69f4 commit b45a94d
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions build-support/githooks/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,7 @@ if git rev-parse --verify "${MERGE_BASE}" &>/dev/null; then
# TODO: add a test case for this while including a pexrc file, as python checkstyle currently fails
# quite often with a pexrc available.
echo "* Checking lint"
./pants --lint-mypy-skip=true --exclude-target-regexp='testprojects/.*' --changed-parent="${MERGE_BASE}" lint || exit 1

echo "* Checking types for targets marked \`type_checked\`"
./build-support/bin/mypy.py || exit 1
./pants --whitelist-tag-name=type_checked --exclude-target-regexp='testprojects/.*' --changed-parent="${MERGE_BASE}" lint || exit 1

if git diff "${MERGE_BASE}" --name-only | grep '\.rs$' > /dev/null; then
echo "* Checking formatting of rust files"
Expand Down

0 comments on commit b45a94d

Please sign in to comment.