Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(auth) improve authentication exception handling #16

Merged
merged 8 commits into from
Oct 15, 2023
Merged

Conversation

pantherale0
Copy link
Owner

@pantherale0 pantherale0 commented Oct 13, 2023

As per title

Improve authentication handling using new exceptions from pynintendoparental 0.1.4

  • Create reauth experience
  • Handle OAuth errors via issues for better visibility
  • Improve the data update coordinator to handle HTTP 401 exceptions more effectively

401 exception on setup will result in an issue being created
400 exception will trigger reauth flows
@pantherale0 pantherale0 mentioned this pull request Oct 13, 2023
4 tasks
@pantherale0 pantherale0 marked this pull request as draft October 13, 2023 23:20
@pantherale0 pantherale0 added the enhancement New feature or request label Oct 13, 2023
(setup) suppress TypeError
(duc) raise UpdateFailed using error
@pantherale0 pantherale0 marked this pull request as ready for review October 15, 2023 12:02
@pantherale0 pantherale0 merged commit 7050f2b into main Oct 15, 2023
3 checks passed
@pantherale0 pantherale0 deleted the reauth branch October 15, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant